issue-1864: Fix fill misbehaving when drawing was partly outside border #1865
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
In addition to fixing the bug not being filled correct, it will also now take the border into account properly, as talked about here. https://discord.com/channels/342369662710972417/342670204351938562/1265361324456804362
|
J5lx
reviewed
Aug 11, 2024
As this is now handled by the fill algorithm, no need for additional checks.
We can't both check whether we're outside and then inside :3 Assuming we should make it seem like the canvas is infinite, it's more appropriate to move the fill point inside the bounds, when we're filling outside the bounds.
When the point is outside the fill bounds
|
Thanks for reviewing Jacob! I've addressed your comment and made some small adjustments in order make the bucket tool always fills within the bounds. The logic for that was already there, it was just being ignored because we had a contradictory check, so I simplified it a bit and now that works too. In practice this just means that when you try to fill outside the bounds of the image, it will move the fill point inside, rather than ignore the fill command. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #1864